Repository navigation
Conversation
Update the Swift code generator to support Proto3 default value omission in _ProtoJSONEncoder while preserving explicit presence for optional and oneof fields. Non-optional singular enum fields are now guarded so default enum values are omitted during encoding. Oneof variants and optional singular Discovery URL-safe byte fields now use encodeIfPresent so explicit zero and empty values remain present in the serialized JSON.
Contributor
There was a problem hiding this comment.
Code Review
This pull request refines Swift code generation by introducing distinct encoding styles, specifically EncodingOptional and EncodingSingularEnum. It updates the field annotation logic to classify fields accordingly and modifies the Swift templates to use encodeIfPresent for optional and oneof fields, and conditional encoding for singular enums to avoid encoding default values. Corresponding unit and integration tests have been added and updated to validate the generated Swift code. There are no review comments, and I have no feedback to provide.
coryan
marked this pull request as ready for review
November 20, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Swift code generator to support Proto3 default value omission in _ProtoJSONEncoder while preserving explicit presence for optional and oneof fields.
Non-optional singular enum fields are now guarded so default enum values are omitted during encoding. Oneof variants and optional singular Discovery URL-safe byte fields now use encodeIfPresent so explicit zero and empty values remain present in the serialized JSON.
Towards googleapis/google-cloud-swift#828
Generated draft at googleapis/google-cloud-swift#1677